Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524346 --- Comment #8 from Chitlesh GOORAH <chitlesh@xxxxxxxxx> 2009-09-24 10:58:56 EDT --- #001: the following should be in the %prep section aclocal autoconf automake -a # Fix up encoding of documentation dos2unix -k AUTHORS iconv -f ISO-8859-1 -t UTF-8 README -o README.new touch -r README README.new mv README.new README # Unpack include files unzip AVR000.zip -d include # Fix permissions and encoding of examples chmod 644 Example/* dos2unix -k Example/* #002: %doc For example, do the following %doc Example instead %doc Example/* This will preserve the examples in a separate directory and not mixing it with other files #003: use %{_datadir} macro instead of /usr/share #004: Directory ownership in %files, add %dir %{_datadir/%{name}-%{version} #004: Preserve timestamps during make install process by adding INSTALL="%{_bindir}/install -p" to your make install Also add "-p" to your install -m 0644 *.inc ..... #005: Add a small on %description stating that fedora also ships some deviced definition *.inc files in %{_datadir/%{name}-%{version}. It will be helpful to the user -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review