Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517643 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flag| |fedora-review+ --- Comment #9 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2009-09-24 11:09:27 EDT --- Review ======= Good: - rpmlint checks return nothing - package meets naming guidelines (PHP) - package meets packaging guidelines (PHP) - license (LGPLv2+ and MIT and BSD) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (53d644dd56fbe58056ba33ff42a58482c86f330e92c9aceefdd86788171a1da2) - package compiles on devel (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review