Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ren https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196434 s.adam@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.adam@xxxxxxxxxxxx ------- Additional Comments From s.adam@xxxxxxxxxxxx 2006-09-21 19:45 EST ------- I'm not a reviewer, as I'm waiting to be sponsored, but I can help out: rpmlint still shows warning on the RPM, I'm not sure if you're absolutely required to fix these as they're minor, but they're there nonetheless: W: ren setup-not-quiet You should use -q to have a quiet extraction of the source tarball, as this generate useless lines of log ( for buildbot, for example ) W: ren macro-in-%changelog defattr Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. W: ren macro-in-%changelog _mandir Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review