Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525304 Matthias Clasen <mclasen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mclasen@xxxxxxxxxx Flag| |fedora-review+ --- Comment #2 from Matthias Clasen <mclasen@xxxxxxxxxx> 2009-09-24 00:07:53 EDT --- formal review: rpmlint: see above package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec language: ok spec legible: ok upstream sources: ok buildable: ok excludearch: n/a build deps: ok locale handling: n/a shared libs: ok bundling: ok directory ownership: ok duplicate files: ok file permissions: ok %clean: ok macro use: ok content: ok large docs: n/a %doc content: ok, but see about about empty files headers: n/a static libs: n/a shared libs: n/a devel deps: ok libtool archives: ok gui apps: n/a file ownership: ok %install: ok utf8 filenames: ok Looks ok. Just take care of the empty files. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review