Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: <Cherokee> Flexible WebServer Alias: Cherokee https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201149 s.adam@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.adam@xxxxxxxxxxxx ------- Additional Comments From s.adam@xxxxxxxxxxxx 2006-09-21 17:37 EST ------- (I'm not a reviewer but just helping out) One of the Fedora Extras guidelines and requirements is to run rpmlint on each package - I ran it on your SRPM and it produced: *** output: *** W: cherokee non-standard-group Productivity/Networking/Web/Servers The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support". E: cherokee no-changelogname-tag There is no %changelog tag in your spec file. To insert it, just insert a '%changelog' in your spec file and rebuild it. E: cherokee unknown-key GPG#6b9d6523 The package was signed, but with an unknown key. See the rpm --import option for more information. E: cherokee no-cleaning-of-buildroot You should clean $RPM_BUILD_ROOT in the %clean section and just after the beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT". *** end output **** Don't worry about the GPG warning, it's just because it's signed with a key rpmlint doesn't know. I don't think you need to worry about the invalid group, although I would make it one of the 'standard' ones just for the sake of getting rid of the warning. The E:'s you should look into, especially the changelog. Another requirement is to have a changelog entry for each release you push, so that's a good one to have! Even if all it says is something like "initial build", that's OK. As long as there's an entry for each version you make. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review