Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524071 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-09-23 17:49:05 EDT --- When naming prereleases, the date in YYYYMMDD format goes before any tag like "bzr" or "svn": http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Builds fine and rpmlint is silent. I note this package provides lua.so and python.so, which is rather unfortunate. I have no idea what you could do about it. The only dependency filtering mechanism I know of can't be used on arch-specific packages. * source files match upstream (checked out and compared manually). X package version oes not meet guidelines for snapshot packages. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. ? final provides and requires: ? lua.so()(64bit) ? python.so()(64bit) lunatic-python = 1.0.1-0.1.bzr20090917.fc12 lunatic-python(x86-64) = 1.0.1-0.1.bzr20090917.fc12 = liblua-5.1.so()(64bit) libpython2.6.so.1.0()(64bit) python(abi) = 2.6 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review