Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520637 --- Comment #7 from Stjepan Gros <stjepan.gros@xxxxxxxxx> 2009-09-23 03:52:40 EDT --- (In reply to comment #5) > For 1.2.4-2: > > * License > - As info files and files under doc/ are under GFDL, the license > tag should be "GPLv3+ and GFDL". Fixed. > * %description > - You don't have to duplicate the same %description into -doc > subpackage. Fixed. > * Conditional BR (BuildRequires) > - INSTALL file says: > ----------------------------------------------------------------- > 140 - User Option: -with-readline[=yes|no] > 141 - User Option: -without-readline > 142 Enables/disables the GNU Readline support for `mixvm'. If the > 143 required libraries are missing (*note Requirements::) the > configure > 144 script with automatically disable this feature. > ----------------------------------------------------------------- > From configure.in, to enable readline support both > "ncurses-devel" and "readline-devel" is needed for BR. > Currently build.log says: > ----------------------------------------------------------------- > 194 checking for initscr in -lncurses... no > 195 configure: WARNING: Cannot find ncurses lib > ----------------------------------------------------------------- > Would you enable this option? Added in BuildRequires ncurses-devel and readline-devel > > * Parallel make > - Support parallel make if possible. If parallel make fails, please > write a note about that on the spec file: > https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make Parallel make doesn't work for this package. I added comment to make. > * About mdk.desktop > - The category "Application;" is deprecated and should be removed. > - The Category line should end with semicolon, i.e. with > "...Emulator;GTK;" . Fixed. > * Timestamps > - Please consider to use > ------------------------------------------------------------------ > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" > ------------------------------------------------------------------ > to keep timestamps on installed files as much as possible. > This method usually works for Makefiles generated from recent > autotools. Fixed. Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/mdk/mdk-1.2.4-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review