Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515230 --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-09-22 21:19:02 EDT --- Here's some quick review commentary. This builds fine; rpmlint says: python-dmidecode.x86_64: E: explicit-lib-dependency libxml2 rpm finds the delepdency on libxml2.so.2 itself; there's no need to specify it manually. python-dmidecode.x86_64: E: explicit-lib-dependency libxml2-python This one seems bogus; ignore it. python-dmidecode.x86_64: W: summary-not-capitalized python extension module to access DMI data Trivial to fix. python-dmidecode.x86_64: W: no-documentation There are several documentation files which should probably be packaged. It is mandatory that you package at least the license file. Source0: should be a full URL to the tarball. If there is no URL where that tarball can be downloaded, where did you get it? Please see http://fedoraproject.org/wiki/Packaging:SourceURL. No supported version of Fedora shipped with a python older than 2.5.2; are you sure the %{python_ver} conditional is needed? (Likewise, no supported Fedora version needs a BuildRoot: tag or the rm line at the beginning of %install.) Nothing seems to own /usr/share/python-dmidecode. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review