Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kbackup - Back up your data in a simple, user friendly way https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207532 aportal@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alain.portal@xxxxxxx ------- Additional Comments From aportal@xxxxxxxxxxxxxx 2006-09-21 13:13 EST ------- (In reply to comment #1) > (I'm no official reviewer so the comment is just a proposal) > > - Use "%configure --disable-rpath" instead of "./configure --disable-rpath" Oups... Fixed > - Not sure about "%{__rm} -rf $RPM_BUILD_ROOT". PackagingGuidelines and > ReviewGuidelines are using simple "rm -rf %{buildroot}" When a macro is available for a command, I prefer use it. > - Not sure about french description. In ReviewGuidelines it is a must, that the > spec is in American English. I don't remember where I saw it, but other language description and summary was a SHOULD Spec URL: http://linuxelectronique.free.fr/download/fedora/5/SPECS/kbackup.spec SRPM URL: http://linuxelectronique.free.fr/download/fedora/5/SRPMS/kbackup-0.4.2-3.src.rpm %changelog * Thu Sep 21 2006 Alain Portal <aportal[AT]univ-montp2[DOT]fr> 0.4.2-3 - Use macro for configure instead of hardcoding path - Use macro style instead of variable style -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review