[Bug 524346] Review Request: avra - ATmel AVR 8-bit RISC microcontroller assembler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524346


Martin Gieseking <martin.gieseking@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking@xxxxxx




--- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx>  2009-09-19 05:29:04 EDT ---
Looks fine to me. Just a couple of notes:

- you should preserve the timestamps of the converted files:
    dos2unix -k AUTHORS
    iconv -f ISO-8859-1 -t UTF-8 README -o README.new
    touch -r README README.new
    mv README.new README

- remove INSTALL from %doc

- NEWS doesn't contain any useful information either. You can drop it too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]