Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hylafax https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188542 ------- Additional Comments From bugs.michael@xxxxxxx 2006-09-21 04:07 EST ------- The %changelog is very out-of-date. > %define faxspool %{_var}/spool/hylafax Since /var is hardcoded pretty much everywhere, e.g. in the initscript, using %{_var} here doesn't add any safety. Just use /var unless it were possible to propagate the value of %{_var} into all relevant files. > %install > [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT > %clean > [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT Both checks are not needed by default and are not reliable. Simply "rm -rf $RPM_BUILD_ROOT" has been used in thousands of packages for many many years. > %makeinstall -e \ If %configure is not used, using %makeinstall makes no sense either. Prefer "make install ..." just like it's correct for most other packages. >>> # Starting from 4.1.6, port/install.sh won't chown/chmod anymore if the current # user is not root; instead a file root.sh is created with chown/chmod inside. # # If you build the rpm as normal user (not root) you get an rpm with all the # permissions messed up and hylafax will give various weird errors. # # The following line fixes that. # [ -f root.sh ] && sh root.sh <<< If this is true, there are packaging errors left somewhere. This comment in the spec file doesn't sound right at least. The rpm must build as normal user and must not rely on chown/chmod. Make sure the %attr(...) settings are complete for any files that really need them and without depending on any execution of chown/chmod. *If*, however, (and I believe you do) you only intended to justify why "root.sh" must be executed when installing Hylafax from tarball as non-root user, the comment is just misleading/confusing. > $ rpm -qlvp hylafax-debuginfo-4.3.0.3-1.i386.rpm > (contains no files) This is because in root.sh (and maybe elsewhere, too) the executables are stripped, which should not be done, and which makes the debuginfo package useless. > drwxr-xr-x uucp uucp 0 /var/spool/hylafax/bin > -rw-r--r-- uucp uucp 14072 /var/spool/hylafax/etc/lutRS18.pcf Wouldn't root:root ownership suffice? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review