Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523650 --- Comment #7 from Colin Coe <colin.coe@xxxxxxxxx> 2009-09-18 07:39:40 EDT --- Initial inspection 1) The changelog entry should be %version-%release i.e. 1.1.1-1 (without the %dist tag) 2) The files section should use macros i.e. /usr/share = %_datadir 3) There is an empty %doc tag 4) The group Application/Music is non-standard 5) Source0 should reference the full downloadable URL for the tarball 6) rpmlint reports mixed use of spaces and tabs on line of the spec file, please try and keep these consistent. Just use one or the other. More comments to follow. CC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review