Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=496697 Colin Coe <colin.coe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.coe@xxxxxxxxx --- Comment #1 from Colin Coe <colin.coe@xxxxxxxxx> 2009-09-17 08:56:36 EDT --- Have had a quick look at this... Looks like you're distributing a binary distribution when the source is available. Could you repackage using the source so that it can be built correctly for Fedora? Also: - You have the URL as 'http://www.ikvm.net' when it should really be the full URL to the source tarball or zip file. Something like 'http://downloads.sourceforge.net/ikvm/ikvm-0.40.0.1.zip'. - Please run 'rpmlint' on the SPEC and SRPM files and correct any errors found - You need to use macros instead of things like '${RPM_BUILD_ROOT}/usr/lib/ikvm'. i.e. ${RPM_BUILD_ROOT}%{_libdir}/ikvm. (On a Fedora or RHEL box, have a look at /usr/lib/rpm/macros) - The use of here documents is discouraged, please include the file as SOURCE1. - The changelog is empty. For the first package release, it should be something like: * Wed Feb 11 2009 Mauricio Henriquez (buhochileno@xxxxxxxxx) - 0.38.0.4-3.2 Initial Packaging I'll review again when the above is addressed. Thanks CC -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review