Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516906 --- Comment #6 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2009-09-16 17:29:02 EDT --- Here's a preliminary review; there are some things to be fixed, packaging-wise, and a build failure. The failures occur on x86_64, whereas you've only tested ix86, but whether ix86 is fine on the server or x86_64 just happened to fail first, you'd have to verify. I'll try building locally on my x86_64 box and see what's going on. MUST • rpmlint $ rpmlint frepple-0.7.1-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. binary not checked yet; builds fail OK package name - matches source tarball OK spec file name - matches package name OK package guideline-compliant OK license complies with guidelines OK license field accurate note: do you have to disable mod_lpsolver? Just make it a subpackage, and license *that* subpackage under the GPL. You'd then want to bundle the GPLv2 COPYING file in the tarball, and rename the LGPL license file to COPYING.LIB OK license file not deleted OK spec in US English FIX spec legible - source tarball listed twice, and Source1 is never used. It's fine to specify a remote URL, as rpmbuild will just strip the remote part of the URL anyway. Using a remote URL is so that, given the spec, someone can use spectool -gf to retrieve the tarball from upstream. - in %build, pass %{?_smp_mflags} to make if possible, for build parallelism - don't hardcode .gz extension for manpage, use * instead OK source matches upstream $ md5sum frepple-0.7.1.tar.gz ../SOURCES/frepple-0.7.1.tar.gz 52c03862345f6247bfda5f7e848457f3 frepple-0.7.1.tar.gz 52c03862345f6247bfda5f7e848457f3 ../SOURCES/frepple-0.7.1.tar.gz FIX builds under >= 1 archs, others excluded xml_remote test fails: F-11 http://koji.fedoraproject.org/koji/taskinfo?taskID=1684341 F-12 http://koji.fedoraproject.org/koji/taskinfo?taskID=1684245 OK build dependencies complete OK library -> ldconfig FIX own all directories going overboard by owning %{python_sitelib} ! Don't own files already owned by Python or Django OK no dupes in %files FIX permission use %defattr(-,root,root,-) OK %clean RPM_BUILD_ROOT OK macros used consistently OK Package contains code FIX large docs => -doc • doc not runtime dependent Rule of thumb is, if it has PDFs and/or more than a couple of HTML files, put them in a separate subpackage OK headers in -devel OK if libfiles are suffixed, the non-suffixed goes to devel OK devel requires versioned base package OK clean buildroot before install ? filenames UTF-8 SHOULD FIX if license text missing, ask upstream to include it include GPLv2 license text when packaging the currently disabled module FIX package build in mock on all architectures ? package functioned as described • other subpackages should require versioned base do this for -doc OK require package not files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review