Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520621 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx Blocks| |177841(FE-NEEDSPONSOR) Status Whiteboard| |NotReady --- Comment #1 from Till Maas <opensource@xxxxxxxxx> 2009-09-16 16:15:54 EDT --- The spec needs a lot of fixing, therefore I added NotReady to the status whiteboard. Please remove it after you have addressed these issues: 1) The spec does not match the srpm, the spec is for version 1.51, but the srpm is for version 1.50 2) GPL is not a valid license tag, it might be GPL+, GPLv2, GPLv2+, ... You can find more information about this here: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#GPL_and_LGPL 3) Vendor and Packager should not be used: https://fedoraproject.org/wiki/Packaging/Guidelines#Tags 4) The Distribution tag should probably not be used, but I asked on fedora-packaging about this 5) The init script should not be started automatically in %post imho, because the user might first want to tweak laptop-mode before it is started 6) %{_usr}/lib/pm-utils/sleep.d must not be owned by laptop-mode-tools, it is owned by filesystem for Fedora Rawhide (F12) 7) The manpages in %files should hava an asterisk appended (*), because in the Fedora buildsystem, the manpages will be gzipped, so the pattern won't match. Also it is not needed to mark them as %doc, this is already done automatically 8) %{_usr}/sbin should be %{_sbindir} and %{_usr}/share %{_datadir}, also it is uncommon to use %{_usr} but to use %{_prefix} instead You also need to block FE-NEEDSPONSOR, because you do not have submitted any package to Fedora. Here is more information about the whole process: https://fedoraproject.org/wiki/Package_Review_Process -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review