Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523715 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx Blocks| |505154(FE-SCITECH) --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-09-16 10:52:47 EDT --- Just some comments after a quick look at your spec file: - You should a disttag to 'Release' -> Release: 1%{?dist} https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Spec_file_pieces_explained - The license is GPLv2+. The source header says 'or (at your option) any later version.' - Source0 should point to the upstream location of the source tarball https://fedoraproject.org/wiki/Packaging/SourceURL - About the Buildroot : https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag - Is there a reason why you don't use 'make %{?_smp_mflags}' https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - You must use macros in the %file section https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Macros - '%defattr(-,root,root)' should be '%defattr(-,root,root,-)' - Preserve the Timestamps when possible in the install section Please reread the Fedora Packaging Guidelines (https://fedoraproject.org/wiki/Packaging:Guidelines) for more details. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review