Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ed2k_hash - Ed2k file hash calculator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207047 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-09-20 11:21 EST ------- I will review this. Well; 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Tags - Add %{?dist} tag. * Encoding - I recommend that the encoding of AUTHORS file is changed from ISO-8859-1 to UTF-8. * Desktop files - Well, I recommend that some icon is installed in -gui package, make desktop file have the entry of the icon name. Perhaps you may get some image file from upstream. If you do so, write it to spec file where you got the image file. If some image conversion is needed (for example, making image file smaller), you can do so and then include the image file to -gui package (then write to the spec file what you have done). 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review