Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520663 Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michael.silvanus@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |michael.silvanus@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2009-09-15 01:46:28 EDT --- This sounds like it should be useful. I'll try and guide you through fixing the current problems, and then I'll sponsor you when the review is complete if everything is satisfactory. Getting a bit late here, so just some preliminary guidelines: - example files: these should be part of the documentation, perhaps for the -devel subpackage or -doc, but not in the base package, as they are really meant for developers' use. Sometimes the standard Makefile results in the examples being built as part of the build process; the easiest way out is for you to make a copy somewhere else within the source tree, maybe in %prep, before the 'make' invocation. Then when packaging, pick this copy of examples, rather than the original - Hidden files: sometimes developers accidentally package editor-created temporary files or (ugh!) OS X metadata files. That's why version-control tools like hg and git have commands to create archive tarballs, but there's nothing us packagers can do apart from cleaning up. You'd want to do this in %install, after make install - Arch-dependent-file: hmm. this, it's hard to say without knowing the specific case (wouldn't want to give you a half-asleep answer either). Let me know if there's anything else that's unclear -- I'll give my preliminary review, with more concrete suggestion, tomorrow, but feel free to update the package before then, of course. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review