Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: whatmask - Convert between different netmask types and show information https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207174 dan@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From dan@xxxxxxxx 2006-09-20 03:13 EST ------- OK, then you could put a note in the changelog for 1.2-3 - something like "derived from private version 1.2-2" Review: - no rpmlint output on any package - package name OK - spec file name OK, is in English and is legible - package meets the Packaging Guidelines - license OK (GPL) and is included - source matches upstream 26aeff74dbba70262ccd426e681dcf4a whatmask-1.2.tar.gz 26aeff74dbba70262ccd426e681dcf4a whatmask-1.2.tar.gz.1 - compiles and builds at least on i386 (devel) - no BuildRequires needed - no localized files - has no shared lib - do not create any directory - no duplicates files, permissions are set properly, uses %defattr - has %clean section - consistent use of macros - contains code - no large docs, %doc is not required during runtime - no devel subpackage required, no pkgconfig file - no .la libtool archives - not a GUI application - it works APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review