Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521947 --- Comment #2 from Martin Nagy <mnagy@xxxxxxxxxx> 2009-09-14 11:16:06 EDT --- Hi, here's some issues that I've found: Package builds successfully in mock. Release starts from 0, should be 1. The summary really doesn't say much. Maybe something along the lines of "Event system based on libtalloc"? Maybe you can copy&paste the description from tevent home page. Copy & paste errors: Summary: Developer tools for the Talloc library A library that implements a hierarchical allocator with destructors. Header files needed to develop programs that link against the Talloc library. Please use %post and %postun with the -p switch as recommended in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries Please don't pass --prefix=%{_usr} to %configure, it is not necessary (see the output of rpm --eval %configure) Unneeded dependencies: libxslt, docbook-style-xsl It seems that the autoconf dependency and running ./autogen.sh is unnecessary, the package seems to build OK without them. Outstanding issues from the review guidelines: MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. rpmlint output: libtevent.x86_64: W: shared-lib-calls-exit /usr/lib64/libtevent.so.0.9.8 exit@xxxxxxxxxxx libtevent.x86_64: W: no-documentation libtevent.x86_64: W: one-line-command-in-%post /sbin/ldconfig libtevent.x86_64: W: one-line-command-in-%postun /sbin/ldconfig 4 packages and 0 specfiles checked; 0 errors, 5 warnings. I couldn't find any documentation myself, so the no-documentation warning is understandable. I already talked about the %post{,un} scriplets. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review