Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520701 David Timms <dtimms@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from David Timms <dtimms@xxxxxxxxxxxx> 2009-09-14 09:58:41 EDT --- (In reply to comment #2) > (In reply to comment #1) > > ? Witold Baryluk's modification is the multithreaded version that is being > > packaged here. I think that explicitly stating that in the Description, and > > with the Source0: comment would be a good idea. > > Added, even though it might be subject to bitrot. OK. > > ? Would it be worth having a script that enumerates connected disks, and > > performs the test on each one, pausing at completion ? And providing a > > desktop file as an easy way to run it ? > > Perhaps, patches welcome ;). Not rocket science but the script should take > root access requirement into account. But I think this can wait until > post-review. Since you were considering packaging it, I can happily hand it > over for you to maintain and improve, or co-maintain if you prefer that... I only thought of this because I did something similar for another one I just submitted for review (tnef #522920). bash/gnome-desktop isn't my fort'e, so any comments on that would be welcome. Will keep it in mind for later. > > ? consider including in %doc the html saveas from the original web site, > > since it gives a decent background on usage. > > Done as upstream gives CC BY-SA 2.5 permission to do that at > http://www.linuxinsight.com/about.html Wow, that looks great (like better than the original web site), I'll have to remember tidy as a useful tool. OK. > New srpm at http://scop.fedorapeople.org/packages/seeker-3.0-2.fc11.src.rpm, > specfile URL unchanged. Checked updated srpm. rpmlints OK, compiles, runs OK. All queries answered, and package updated as suggested. ===== As I can see Ville is an existing contributor and sponsor in Fedora, I (David Timms) hereby approve the package seeker. ===== -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review