Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519221 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review?, |fedora-review+ |needinfo?(rpm@xxxxxxxxxxxxx | |t) | --- Comment #6 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2009-09-13 08:47:30 EDT --- (In reply to comment #3) > re: comment 2 -- your kernel doesn't have support for /dev/rfill. I assure you > that it works fine here. :-) kernel-2.6.30.5-43.fc11.x86_64 here. Which one do I need to have /dev/rfkill? > re: comment 1 -- I think rfkill.c would be fine if the COPYING file was a bit > more clear. But the rfkill.h having come from the kernel throws the whole BSD > license claim into doubt. :-( I'll see if I can get that sorted-out > upstream... Excellent! Though I really suggest adding that BSD license to the top of rfkill.c to avoid any confusion in the future. (In reply to comment #4) > Spec URL: http://linville.fedorapeople.org/rfkill.spec > SRPM URL: http://linville.fedorapeople.org/rfkill-0.3-1.fc11.src.rpm Looks fine now, although using the improved summary and description suggested by Tomasz above will earn you extra karma. :) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review