Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520322 --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-09-12 14:39:42 EDT --- Well, for 0.7.3-1 * Timestamps - Now this package installs more files, keeping timestamps on installed files as much as possible is preferable. Please consider to use ------------------------------------------------------ make install DESTDIR=%{buildroot} INSTALL="insatll -p" CPPROG="cp -p" ------------------------------------------------------ to keep timestamps on installed files. - Usually adding INSTALL="insatll -p" works for makefiles based on Makefiles generated from recent autotools - However this package also uses "install-sh" to install files. For this, adding CPPROG="cp -p" will (usually) keep timestamps on installed files. * redundant %doc - Files under %{_mandir} are automatically marked as %doc. - Also files under %{_docdir} are automatically marked as %doc. * Directory ownership issue - This is actually under discussion, however this package installs some files under %{_datadir}/aclocal/ and currently owned by "automake" rpm. So adding "Requires: automake" to this package is preferable to satisfy directory ownership issue. - -docs package installs some files under %{_docdir}/%{name}/, however the directory %{_docdir}/%{name} is not owned by any packages, which should be owned by "this" (i.e. mm-common-docs) package: https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Forgetting_to_Include_a_Toplevel_Directory ! %changelog - I recommend to add entries into %changelog even this is still under review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review