Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516058 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steve.traylen@xxxxxxx --- Comment #3 from Steve Traylen <steve.traylen@xxxxxxx> 2009-09-11 14:16:23 EDT --- Hi, This all looks good, it is of course incredibly simple from a packaging point of view. $ rpmlint SPECS/php-email-address-validation.spec \ SRPMS/php-email-address-validation-0-0.2.20090910svn.fc11.src.rpm \ RPMS/noarch/php-email-address-validation-0-0.2.20090910svn.fc11.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. A mock build is fine. It clearly is BSD licensed but if you could encourage upstream to include a LICENSE file that would be good. The PHP guidelines mentioned above. <quote> Other Packages PHP addons which are neither PEAR nor PECL should require what makes sense (either a base PHP version or a php-api, php(zend-abi) as necessary). </quote> suggest to me that php should be a requirement and given this does not work with out php installed this makes perfect sense to me. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review