Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vkeybd - Virtual MIDI Keyboard https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189889 ------- Additional Comments From opensource@xxxxxxxxx 2006-09-19 10:16 EST ------- just remove your COPYING file and proceed. Hopefully there will be a new release sometime with the file added. Here are some other items that need to be taken care of: - move the .desktop file to a separate file - I think the invocation of "update-desktop-database %{_datadir}/applications" is not needed. According to http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28update-desktop-database%29#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef it is only need when the .desktop file has an MimeType entry - then you do not need "Requires(post): desktop-file-utils" and "Requires(postun): desktop-file-utils" - I am not sure, but $RPM_BUILD_ROOT/%{_datadir}/icons/vkeybd.png seems not the be the correct location for the icon since on my system all other icons are in subdirectories of icons, e.g. hicolor/<size> - alsa-lib-devel, jack-audio-connection-kit-devel and e2fsprogs-devel can be removed from BuildRequires since they are already required by lash-devel - tcl-devel can be removed from BuildRequires since it is already required by tk-devel if the versioned dependency can be done with tk-devel instead of tcl-devel and please do not forget the issues in comment 5 and 6 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review