[Bug 516058] Review Request: php-email-address-validation - A PHP class for validating email addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516058





--- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx>  2009-09-09 20:50:07 EDT ---
A couple of comments:

%description doesn't actually say what the package does.  The project history
isn't really relevant for a package description.

There's no instructions for duplicating the included tarball as required by
http://fedoraproject.org/wiki/Packaging:SourceURL

This package has no dependencies at all.  At the very least it would have to
depend on php-common so that /usr/share/php is owned correctly.  More likely it
should depend on php itself.
http://fedoraproject.org/wiki/Packaging:PHP#Other_Packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]