[Bug 450527] Review Request: libkni3 - C++ library for the Katana robot arm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450527


Jason Tibbitts <tibbs@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #23 from Jason Tibbitts <tibbs@xxxxxxxxxxx>  2009-09-09 19:57:16 EDT ---
OK, finally things have calmed down from the new semester and I have some time
to look at this.

Note the spec URL above has a typo; s/,/./.

Everything does build and it all looks pretty good to me.  The only weird thing
I see now is  that you have a package "libkni3-doc" that installs files in
/usr/share/doc/libkni3-docs.  It seems that the name of the package and the
name of the directory should match.

Otherwise I think everything is OK.  The above is minor, and while I think it
would be good to fix it before the package is imported, I don't think there's
any point in waiting for an updated package before I approve this.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]