Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=522148 Adel Gadllah <adel.gadllah@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adel.gadllah@xxxxxxxxx Flag| |fedora-review? --- Comment #2 from Adel Gadllah <adel.gadllah@xxxxxxxxx> 2009-09-09 12:12:25 EDT --- ==== REVIEW === [+] source files match upstream: 4a67db39035533d3cf17b0f31355a42d7cd49270 [+] package meets naming and versioning guidelines. [+] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible: GPLv2+ and CC-BY [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [+] %clean is present. [+] package builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1665688 [+] package installs properly. [-][1] rpmlint is silent. [+] final provides and requires are sane: sound-theme-fedora = 1.0-2.fc12 ---- rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 sound-theme-freedesktop rpmlib(PayloadIsXz) <= 5.2-1 [+] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no headers. [+] no pkgconfig files. [+] no libtool .la droppings. === COMMENTS ==== 1) sound-theme-fedora.noarch: E: zero-length /usr/share/sounds/Fedora/stereo/tooltip-popup.disabled I suppose this is on purpose to silence the tooltip sound, correct? 2) AUTHORS not packaged and no parallel make (one might argue that both does not make sense for this package) Please comment on them and I will approve the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review