Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521458 Chitlesh GOORAH <chitlesh@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Chitlesh GOORAH <chitlesh@xxxxxxxxx> 2009-09-08 15:11:52 EDT --- #001 ExclusiveArch: %{ix86} x86_64 Add a comment to the spec file explaining the reason for this line. #002: Remove perl from BR Your http://koji.fedoraproject.org/koji/getfile?taskID=1662810&name=root.log shows that perl was installed as part of the build system minimal package set, then afterwards koji reads what you have listed as BR. #003: Add a check section before %clean: ------------------ # Fedora Electronic Lab: Package Self Check %check %{__make} check ------------------ make check fails. Please notify upstream for correction. Since he is quite responsive maybe he can dump a new release. Please invite him to add himself as CC: or comaintainer of this package. running 'builder-search' test... subtest: case1...diff: regression/builder-search/case1.v: No such file or directory fail FAIL: builder3.pl #004: Preserve timestamps during make install add the following to your make install : INSTALL="%{_bindir}/install -p" #005: use make macro everything %{__make} #006: No need to package the %docs twice. Both main package and subpackage should not own %doc README COPYING doc/html/ doc/latex/ #007: replace your %make install process : -------------------------- make prefix=%{buildroot}%{_prefix} \ bindir=%{buildroot}%{_bindir} \ libdir=%{buildroot}%{_libdir} \ includedir=%{buildroot}%{_includedir} \ mandir=%{buildroot}%{_mandir} \ install ------------------- by %{__make} INSTALL="%{_bindir}/install -p" install DESTDIR=%{buildroot} after you have added the following in %prep %{__sed} -i "s|^MYDOCDIR = |MYDOCDIR = \$(DESTDIR)|" doc/Makefile* #008: Both doc/html/ and doc/latex/ seem to be outputs of doxygen. Should not we just take doc/html (-devel package)? #009: doc/faq.html should be added to %doc of the main package #010: contents of %{_datadir}/%{name}-%{version}/ should be in %doc of the main package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review