Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: hugin - Frontend for Panorama Tools, similar to PTAssembler, PTGui or Open for Windows https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206814 ------- Additional Comments From bruno@xxxxxxxxxx 2006-09-18 16:14 EST ------- (In reply to comment #6) > > 1. The mono stuff needs to be a subpackage, call it hugin-mono or something There isn't any mono code in hugin. autopanog is in another package which I won't be submitting as the basic algorithm is US patented and hugin runs fine without it. The fix in the spec is a convenience thing for users who do want to install it. > 2. You have a desktop icon in %{datadir}/applications but nothing in the spec > 3. You have icons and the such as well as mime information in %datadir which is > not handled. Thanks, hadn't found this stuff before. Should be fixed. > 4. ldconfigs not required - no libs being installed Fixed. > Also even on x86_64, you will have had a debuginfo package generated. Nope. I guess there is something wrong with my system as x86_64 RPMs never get stripped and I get no debuginfo packages. I'll ask upstream what the situation is with all the .la libraries that get statically linked. I think this is just a case of programming style, they are not intended to be exported. SPEC URL: http://bugbear.blackfish.org.uk/~bruno/apt/SPECS/hugin.spec SRPM URL: http://bugbear.blackfish.org.uk/~bruno/apt/fedora/linux/5/x86_64/SRPMS.panorama/hugin-0.6.1-4.fc5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review