Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459855 Jarod Wilson <jwilson@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwilson@xxxxxxxxxx --- Comment #12 from Jarod Wilson <jwilson@xxxxxxxxxx> 2009-09-04 15:05:06 EDT --- Stepping in on this one... 1) There are muliple "for SCRIPT in ncidd ncidsip ncidsip" lines in the spec. I doubt ncidsip needs to be done twice. 2) In %files, use standard macros for /usr/bin (%{_bindir}), /usr/sbin (%{_sbindir}), /usr/share (%{_datadir}), etc. 3) I'd argue that ncid-mythtv is an acceptable sub-package. Sure, its useless without mythtv running on your network somewhere, but we have all sorts of software that is in the same boat -- MPD frontends, libvdpau just approved today by FESCo, libXNVCtrl, the totem-mythtv plugin (probably the best example, as to be really useful, you need a mythtv backend on your network, and likely assorted codecs mythtv doesn't ship to play back mythtv recordings in totem), etc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review