Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490988 Adam Williamson <awilliam@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |awilliam@xxxxxxxxxx Flag| |fedora-review? --- Comment #9 from Adam Williamson <awilliam@xxxxxxxxxx> 2009-09-04 14:38:35 EDT --- This was approved by FESco today, so I'm taking it for review. Couple of things. You can simplify the exclusivearch stuff: %if 0%{?fedora} > 11 || 0%{?rhel} > 5 ExclusiveArch: i686 x86_64 %else %if 0%{?fedora} == 11 ExclusiveArch: i586 x86_64 %else ExclusiveArch: i386 x86_64 %endif (put the else and if on one line, and that lets you remove one endif - it's all one clause, then). As I understand the versioning policy, there should be a . between the revision (5, at present) and the git date bit. It should be libvdpau-0.1-0.5.git20090902.fc11 , not libvdpau-0.1-0.5git20090902.fc11 - see the examples at http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages . rpmlint throws an invalid-soname error on libvdpau-trace.so . It's an unversioned lib in %{_libdir} (not a subdirectory) in a non-devel package, which is unusual. What exactly is it used for? Should it be versioned, or put in a subdirectory? Aside from the above, package looks good to me. rpmlint output: [adamw@adam SRPMS]$ rpmlint libvdpau-0.1-0.5git20090902.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [adamw@adam SRPMS]$ rpmlint ../RPMS/x86_64/libvdpau-0.1-0.5git20090902.aw_fc12.x86_64.rpm libvdpau.x86_64: W: incoherent-version-in-changelog 0.1-0.5git20090902 ['0.1-0.5git20090902.aw_fc12', '0.1-0.5git20090902.aw_fc12'] libvdpau.x86_64: E: invalid-soname /usr/lib64/libvdpau_trace.so libvdpau_trace.so 1 packages and 0 specfiles checked; 1 errors, 1 warnings. [adamw@adam SRPMS]$ rpmlint ../RPMS/x86_64/libvdpau-devel-0.1-0.5git20090902.aw_fc12.x86_64.rpm libvdpau-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review