Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513420 --- Comment #12 from Peter Robinson <pbrobinson@xxxxxxxxx> 2009-09-03 18:28:16 EDT --- An initial review. The summary and description still need to be fixed. Other than that there's only a couple of small bits. - rpmlint output rpmlint whaawmp-0.2.12.1-1.fc11.src.rpm whaawmp-0.2.12.1-1.fc11.noarch.rpm whaawmp.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/whaawmp/whaawmp.py 0644 /usr/bin/env whaawmp.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/whaawmp/thumbnailer.py 0644 /usr/bin/env 2 packages and 0 specfiles checked; 2 errors, 0 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 259b61cfa87bbba54dcd9579a815a421 whaawmp-0.2.12.1.tar.bz2 + package successfully builds on at least one architecture tested using koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=1653577 + BuildRequires list all build dependencies + %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates + no duplicate files in %files + Package perserves timestamps on install + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base n/a packages should not contain libtool .la files + packages containing GUI apps must include %{name}.desktop file - packages must not own files or directories owned by other packages I'm not sure why both packages need to own this? # We need to own this dir although it's already owned by Thunar %dir %{_datadir}/thumbnailers/ + %install must start with rm -rf $RPM_BUILD_ROOT etc. + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji n/a the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review