Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516114 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Paul Howarth <paul@xxxxxxxxxxxx> 2009-09-03 10:08:07 EDT --- rpmlint output: trac-accountmanager-plugin.src: W: strange-permission pull-from-svn.sh 0775 2 packages and 0 specfiles checked; 0 errors, 1 warnings => harmless Review checklist: - package name OK and matches other trac plugins in distribution - spec file name OK - package meets guidelines - license OK and matches upstream - no detached license file - spec file written in English and is legible - no upstream tarball to compare sources with, but pull-from-svn script provided - package builds in mock for F-11 and Rawhide; package not appropriate for F-10 due to trac >= 11.0 requirement - buildreqs OK - no locale data, subpackages, libraries, devel files, or scriplets to worry about - package not intended to be relocatable - no duplicate files or directory ownership issues - %defattr and %clean present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - not a GUI app, no desktop file needed - all filenames are ASCII - package functions as expected (see http://www.city-fan.org/tips/TracWithFastCGIonFedora for example setup) - no file dependencies No issues there then. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review