Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520637 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2009-09-03 02:59:49 EDT --- I had a quick look at your package and noticed the following things that should be fixed. I'm not a sponsor, though. - according to the source files the license tag should be GPLv3+ - you can remove the following redundant dependencies: BuildRequires: glib2-devel BuildRequires: pango-devel BuildRequires: gtk2-devel - since the package ships with a GUI application, you must include a .desktop file (see https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files) - the sample files should go in a -doc subpackage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review