Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fedora-xgl-settings https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192438 ------- Additional Comments From s.adam@xxxxxxxxxxxx 2006-09-17 22:02 EST ------- rpmlint isn't silent on the SRPM: W: 3ddesktop no-url-tag E: 3ddesktop invalid-spec-name 3ddesktop-configurator.spec Your spec filename must end with '.spec'. If it's not the case, rename your file and rebuild your package. W: 3ddesktop rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will break short circuiting. E: 3ddesktop no-cleaning-of-buildroot You should clean $RPM_BUILD_ROOT in the %clean section and just after the beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT". W: 3ddesktop mixed-use-of-spaces-and-tabs The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review