Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sqlgrey - postfix grey-listing policy service https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189188 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-17 20:03 EST ------- I'd be happy to take over this review... OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: b84931d638c3527e2dabc26ad6754bc0 sqlgrey-1.7.4.tar.bz2 b84931d638c3527e2dabc26ad6754bc0 sqlgrey-1.7.4.tar.bz2.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: See below - Should include License or ask upstream to include it. OK - Should build in mock. Builds ok on fc6 i386|x86_64 and fc5 i386|x86_64. OK - Should have sane scriptlets. Issues: 1. Might include the gpl COPYING file? 2. Might include the Changelog and CONTRIB as %doc files? 3. rpmlint says: W: sqlgrey conffile-without-noreplace-flag /etc/sqlgrey/README Does this need to be in /etc/sqlgrey? Or can it be in doc? E: sqlgrey non-standard-uid /var/lib/sqlgrey sqlgrey E: sqlgrey non-standard-gid /var/lib/sqlgrey sqlgrey E: sqlgrey non-standard-dir-perm /var/lib/sqlgrey 0750 All those can be ignored I think. 4. Have you been able to determine the issue from comment #6 about it not working? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review