Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520808 --- Comment #2 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2009-09-02 15:06:46 EDT --- (In reply to comment #1) > - package builds and installs fine on x86 > X please make the description for the javadoc package "API documentation for > %{name}" Done. > X many of the lines are > 80 characters; please fix Done wherever possible > X I think we need some Requires on java and jpackage-utils Done > - licensing good (some files are missing license headers but I'm willing to > accept [1]. we should perhaps press to get these added in git master) > - rpmlint clean (except ignorable maven thing): > > $ rpmlint /home/overholt/rpmbuild/SRPMS/slf4j-1.5.8-2.fc11.src.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > $ rpmlint /home/overholt/rpmbuild/RPMS/noarch/slf4j-1.5.8-2.fc11.noarch.rpm > slf4j.noarch: W: non-conffile-in-etc /etc/maven/fragments/slf4j > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > $ rpmlint > /home/overholt/rpmbuild/RPMS/noarch/slf4j-javadoc-1.5.8-2.fc11.noarch.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > $ rpmlint > /home/overholt/rpmbuild/RPMS/noarch/slf4j-manual-1.5.8-2.fc11.noarch.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > - macros and clean sections present and fine > - sources match upstream (md5sum) > X please move to (-,root,root,-) for the %files %defattrs Done > > [1] > http://marc.info/?l=slf4j-user&m=119773193423413&w=2 New sources: Spec URL: http://akurtakov.fedorapeople.org/slf4j.spec SRPM URL: http://akurtakov.fedorapeople.org/slf4j-1.5.8-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review