[Bug 520322] Review Request: mm-common - common files for GNOME C++ bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520322


Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka@xxxxxxxxxxxxxxxxxxx




--- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx>  2009-09-02 14:40:47 EDT ---
Some notes:

* Version
  - It seems that the latest version is 0.7.2.

* License
  - As http://gcc.gnu.org/onlinedocs/libstdc++/ says libstdc++ documents
    are under GFDL, the license tag should be "GPLv2+ and GFDL".

* About BR and its releated comments
---------------------------------------------------------
# mm-common uses curl or wget to download the most recent libstdc++.tag.
---------------------------------------------------------
  - ... but during build process nothing is to be downloaded.
    ( and koji (Fedora buildsystem) does not allow to download anything
      during rpmbuild )
    Would you clarify what you mention here?

  - By the way does this package need rebuild every time the (libstdc++)
    upstream doctags/libstdc++.tag is updated?
    ( Again on koji, no net connection is supported during rpmbuild
      process )

  - Would you check if autoconf/automake is really needed for
    BuildRequires? They don't seem to be needed.


* Macros
  - Please use macros properly. /usr/bin should be %{_bindir}.
    https://fedoraproject.org/wiki/Packaging/RPMMacros

  ! Note
    - For consistency I would suggest that "Requires: libxslt" should be
      used instead of "Requires: %{_bindir}/xsltproc", however I guess
      you want to suppress rpmlint "error" about explicit-lib-dependency.
      So if you want to use "Requires: %{_bindir}/xsltproc", I won't
      object to it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]