Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=520491 --- Comment #3 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2009-09-01 06:35:32 EDT --- (In reply to comment #2) > OK, here are just a few issues: > > - remove BR: maven2-plugin-surefire (obsoleted by maven2) It is needed during the build. Changed to the obsoleting package maven-surefire-maven-plugin. > - is there any reason to use the Epoch: 0 tag? If not please remove it. Removed. > - the creation of local maven repository could go into the with_maven > conditional No. It can not go because ant build.xml is generated by mvn ant:ant which requires maven repository to work. > > Otherwise the package is sane: > + follows general guidelines (proper licensing, builds from source, proper > instructions for getting source, ...) > + follows Java guidelines (builds with maven in offline repo, installs into > proper maven locations, docs are in -javadoc, ...) > + builds in current rawhide: > https://koji.fedoraproject.org/koji/taskinfo?taskID=1647555 > > Provided the BR & Epoch mentioned above will be fixed when importing, this > package is APPROVED. New sources: Spec URL: http://akurtakov.fedorapeople.org/maven-embedder.spec SRPM URL: http://akurtakov.fedorapeople.org/maven-embedder-2.0.4-6.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review