[Bug 517144] Review Request: ghc-HUnit - unit testing support for Haskell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517144


Jens Petersen <petersen@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Reopened
             Status|CLOSED                      |ASSIGNED
                 CC|                            |petersen@xxxxxxxxxx
         Resolution|CURRENTRELEASE              |




--- Comment #6 from Jens Petersen <petersen@xxxxxxxxxx>  2009-08-31 05:55:59 EDT ---
(In reply to comment #1)
> MUST: The sources used to build the package must match the upstream source, as
> provided in the spec URL. Reviewers should use md5sum for this task. If no
> upstream URL can be specified for this package, please see the Source URL
> Guidelines for how to deal with this.
> >>> CHECK -> Presuming innocence here re: using the official tarballfor the Platform project.

I didn't understand this comment: the reference src tarball is from hackage.

> MUST: Packages must not own files or directories already owned by other
> packages. The rule of thumb here is that the first package to be installed
> should own the files or directories that other packages may rely upon. This
> means, for example, that no package in Fedora should ever share ownership with
> any of the files or directories owned by the filesystem or man package. If you
> feel that you have a good reason to own a file or directory that another
> package owns, then please present that at package review time. [24]
> >>> CHECK

> SHOULD: The reviewer should test that the package functions as described. A
> package should not segfault instead of running, for example.
> >>> CHECK

Errm, HUnit is already in ghc....

So do we remove HUnit from ghc or drop this package for now?

Looks like a typo in haskell-platform.cabal to me?
Or am I totally confused?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]