Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515832 --- Comment #7 from Sean Middleditch <sean@xxxxxxxxxxxxxx> 2009-08-30 20:07:23 EDT --- Indeed, I put the wrong URL. Corrected. I have a requirement on buildrequires for those because I believed them to be needed. I suppose automake, autoconf, libtool are only needed to regenerate the files shipped in the dist tarball, so they are removed. I try to avoid those things wherever possible and only even used them in libtelnet because RPM made it very difficult to work without them. Removed the build requires. zlib-devel is required because it's supposed to be building against zlib, but apparently I forgot to include that in the configure script I wrote. Whoops. Removed for now, will re-add when I release 0.11 with an updated configure script. Replaced use of %makeinstall. I got that from the Fedora examples. I'm getting rather irritated by the Fedora documentation being contradictory and out of date for package building. Fixed the two places I forgot the fourth parameter to %defattr. So far as the package structure, the packaging guidelines didn't offer any advice. Other distros I've packaged for try to avoid putting binaries in lib* packages, and frankly I agree with that -- the people who need the library probably do not need the other utilities, which would just make /usr/bin that much bigger and more full of unnecessary crap. If individual binary RPMs are undesirable in Fedora, I would prefer to put the binaries into a libtelnet-utils or libtelnet-bin package like libproxy does., so people can get libtelnet on its own without the chaff. I will update to do just that. Not sure why you felt the need to tell me to update the release number when I've only ever posted one version of the spec file so far. The new spec file has the appropriate updates. http://middleditch.us/sean/libtelnet.spec http://middleditch.us/sean/libtelnet-0.10-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review