Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509856 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #8 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-08-29 14:41:35 EDT --- Some random comments ? About enabling tests - As this package contains tests/ directory, it is usually highly recommended that you add %check section and execute some test program there. However for this package to execute test_all.sh under tests/ directory we have to add "--with-tests" option explicitly to configure - because without this option some symbols needed for test program are marked as "static" and these symbols are not included in libqrencode.so. i.e. when "--with-tests" option is added to configure, it will add some addtional symbols to libqrencode.so which seems to be used only the test program in this tarball. So while I think generally executing test program is preferable, for this package I am not sure. How do you think? * Timestamps - Please consider to use ----------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ----------------------------------------------------------------- to keep timestamps on installed files as much as possible (especially on header files). This method usually works for Makefiles generated from recent autotools. * pkgconfig file - Currently I don't see any reason why pkgconfig file should be deleted. This pkgconfig file may be used by other applications. * Documents - You don't have to add documents to subpackages which are already included in the main package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review