[Bug 505264] Review Request: wb_builder - Wishbone Bus Builder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505264


Shakthi Kannan <shakthimaan@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shakthimaan@xxxxxxxxx




--- Comment #2 from Shakthi Kannan <shakthimaan@xxxxxxxxx>  2009-08-29 13:09:56 EDT ---
While the package runs, I am not convinced with the code design. Maybe, a
person learning Perl can re-do the design part. I have tried using strict,
warnings, and it has yielded lot of errors, and warnings. Is it ok to not use
strict, warnings? Otherwise, package looks ok.

Attached patch, fixes some Perl strict warnings and errors, but, please
double-check that it doesn't alter the wishbone logic, as I am not familiar
with the domain, yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]