Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506825 --- Comment #16 from Christoph Wickert <christoph.wickert@xxxxxxxxxxxxxx> 2009-08-29 09:46:34 EDT --- Sorry for the delay, it was a busy week for me. Good: - Requires/Requires(pre,post,postun) are sane - Requires of devel package are sane to, gtk-doc was dropped - License was clarified, license tag matches - bickley-0.4.pc fixed for 64 bit Bad: - Some redundant BRs that *could* (not must) be removed: clutter-devel and clutter-gtk-devel require gtk2-devel clutter-gtk-devel and clutter-gst-devel require clutter-devel - I wonder if "Applications/Multimedia" really is the proper group tag for a framework. - Are sqlite and xdg-user-dirs really required? I dont't see them referenced in the source - %configure is still run twice. - %configure correctly uses --disable-rpath and --disable-schemas, but now during build I see: configure: WARNING: unrecognized options: --enable-maintainer-mode ... configure: WARNING: unrecognized options: --disable-rpath, --disable-schemas the first is a bug in autogen.sh and should be fixed upstream, but the second ones need fixing in the package. --disable-shemas can be dropped as you already have export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1 in %install This leaves --disable-rpath. I'm pretty sure I checked that it works, but AFAIKS it can be dropped too as the applications contain no rpath (tested with chrpath). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review