Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519071 Christoph Wickert <christoph.wickert@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christoph.wickert@googlemai | |l.com --- Comment #2 from Christoph Wickert <christoph.wickert@xxxxxxxxxxxxxx> 2009-08-28 17:45:28 EDT --- Pleas note that %post /usr/bin/update-desktop-database -q || : %postun /usr/bin/update-desktop-database -q || : is not necessary, because the desktop file contains no mimetype. This is only needed it an application is supposed to open a certain mime type, so the "Open with..." entry gets created. And of course, Requires(post): desktop-file-utils Requires(postun): desktop-file-utils are not necessary ether. This would only be neccessary if there was a mime type AND you want to build this package on EPEL/Fedora < 5, see https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database I don't like the summary. Summary should be short an precise but not whole sentences. How about: "Tool to control applications or presentations with a Wiimote"? I didn't test it, but %if 0%{?fedora} <= 11 BuildRequires: xorg-x11-proto-devel %else BuildRequires: libXi-devel %endif looks bogus to me, as libXi-devel requires xorg-x11-proto-devel. %{_mandir}/man1/wiipresent.1* does not need to be tagged as %doc, rpmbuild will take care of this. It doesn't do no harm, it's just a hint. Finally: the build root tag should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) or even better %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) Doesn't really matter ether, but IMO for new packages we should follow the guidelines from https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag That's all from my side, nothing more to add. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review