Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519483 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@xxxxxxxxx --- Comment #1 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2009-08-26 20:52:53 EDT --- quick pre-review of important things: * Licensing looks good. Mixture of GPL and MIT. There is no included license file but hte source references: GNU/GPL - http://www.gnu.org/copyleft/gpl.html * The module includes a copy of livepipe which is not a blocker as it is a javascript library and we don't yet have javascript guidelines. Something that will need to be moved out into its own package in the future, though. * There is an included version of FilterUtil: http://code.zikula.org/filterutil that seems like it should be in its own package. Is there a reason it shouldn't? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review