Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493013 --- Comment #5 from Till Maas <opensource@xxxxxxxxx> 2009-08-26 17:32:57 EDT --- Spec URL: http://till.fedorapeople.org/review/dzen2.spec SRPM URL: http://till.fedorapeople.org/review/dzen2-0.8.5-4.fc10.src.rpm - use make -C instead of pushd/popd - add manpages from debian - prefix gadgets with dzen2 like debian does it - export LDFLAGS - explain missing .desktop file (In reply to comment #4) > SHOULD: If the package does not include license text(s) as separate files from > upstream, the packager should query upstream to include it. NEEDSWORK > - License text is not included in the tarball, please ask upstream to include > it. I guess you did not see the file LICENSE that is also included in %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review