Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518083 --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-08-26 15:06:53 EDT --- Well, - Please fix the following rpmlint warning: ------------------------------------------------------------- rubygem-pathname2.noarch: W: summary-ended-with-dot An alternate implementation for the Pathname library. ------------------------------------------------------------- Fedora suggests that Summary should not end with dot. ! Well, maybe you like to use underscore, however you can use hyphen in patch name (just noting). - Source1 should be changed to Patch0 (as this is a patch) - By the way usually applying a patch should be done at %prep and use %patchX macro which rpm provides. Current ruby packaging guideline suggests that ruby gem file should be installed under %buildroot at %install directly, however when applying a patch or executing test is needed, I usually suggest to once unpack gem file under %_builddir and copy the unpacked tree to %buildroot at %install like: --------------------------------------------------------------- %prep %setup -q -c -T %{__mkdir_p} .%{gemdir} gem install --local --install-dir=.%{gemdir} \ --force --rdoc %{SOURCE0} pushd .%{geminstdir}/test %patch0 -p0 popd %build %install %{__rm} -rf %{buildroot} %{__mkdir_p} %{buildroot}%{gemdir} %{__cp} -a .%{gemdir}/* %{buildroot}%{gemdir}/ %check ruby -I$(pwd)%{geminstdir}/lib $(pwd)%{geminstdir}/test/test_pathname.rb %clean ----------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review