Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519236 Andrew Overholt <overholt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|needinfo?(overholt@xxxxxxxx | |om) | --- Comment #3 from Andrew Overholt <overholt@xxxxxxxxxx> 2009-08-26 11:06:29 EDT --- (In reply to comment #2) > 1. Packaging naming convention has the number incrementing ahead of the > alphatag. So release should be 0.2.a4 and then 0.3.a4 etc.. Oops, fixed. > 2. Javadoc description should not reference itself (use API documentation for > xxx) Fixed. > 3. No %doc files There's nothing to mark %doc. > 4. post and postun sections are maven-only. Is this a problem since with_maven > is 0? No. > 5. defattr non-standard. Fixed. Updated spec and SRPM: http://overholt.fedorapeople.org/plexus-resources.spec http://overholt.fedorapeople.org/plexus-resources-1.0-0.2.a4.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review